markbates / markbates/goth

Azure AD V1/V2 not able to read groups claims

Open
#449 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
6.6k
Forks
631
PR merge metrics
No merged PRs in 30d

Description

  1. In the latest Gitea 1.16, when I specify the claim name 'groups' and an Azure AD group ID it doesn't seem to do anything. I am trying to get the 'is admin' populated based on a Group ID.

  2. The userid is the object ID of the user in Azure AD. Can this be the first part of the UPN instead?

https://github.com/markbates/goth/blob/master/providers/azureadv2/azureadv2.go

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Azure AD V2 provider in azureadv2/azureadv2.go, then trace how claims and the user ID are read. Verify the behavior against the two requested Azure AD cases: group claims should support the stated group ID for admin mapping, and the user ID behavior should match the requested UPN form.

Written by the indexing model from the issue text.

Assessment

Tech stack
azure, go
Domain
authentication, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.