markbates / markbates/goth

App Review for Facebook Login

Open
#223 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
6.6k
Forks
631
PR merge metrics
No merged PRs in 30d

Description

Hi,

I have received notices that I have to get App Reviews, might I suggest removing from the endpointProfile string the link and location profile properties in facebook.go since these require an App review.

In the long run, or short, having a field to add more properties would be beneficial giving developers the option to request an App review and this would allow for less complications in developing an App.

I removed them and rebuilt my projects and when I logged back in after deleting the App there were no special permissions requests.

Thanks

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in facebook.go and inspect the endpointProfile string and the link and location properties mentioned in the issue. Confirm whether the intended change is to remove those properties or make requested properties configurable, then verify the resulting Facebook Login behavior and add or update coverage if the repository provides relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
authentication
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.