markbates / markbates/goth

cannot logout properly without provider information

Open
#170 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
6.6k
Forks
631
PR merge metrics
No merged PRs in 30d

Description

Hello,

Goth stores its session information on session store with provider name, like `gplus_gothic_session` and logout function `gothic.Logout()` searches and uses the provider name for clearing the session.

So, the App using Goth must remember the provider used by current login per sessions (store in session or similar method), even though I do not care where they coming from.

I wonder why it uses the session name with provider name. If it was just `_gothic_session`, it is more simple to handle on the App. Is there any reason to use `provider_gothic_session`?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at gothic.Logout() and trace how the provider-specific session name, such as `gplus_gothic_session`, is selected and cleared. Compare that behavior with the login session flow; done means the issue's provider-information requirement or a simpler session naming approach is resolved without breaking logout.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
authentication, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.