markbates / markbates/deano

Invalid Byte Sequence

Open
#1 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
3
Forks
2
PR merge metrics
No merged PRs in 30d

Description

When I try to create a new app with deano, I get an invalid byte sequence when performing a gsub on OS X ML 10.8.3

```
mkdir london_price
mkdir -p /Users/allen/proj/london_price/london_price/apps
mkdir -p /Users/allen/proj/london_price/london_price/apps
mkdir -p /Users/allen/proj/london_price/london_price/apps/views
mkdir -p /Users/allen/proj/london_price/london_price/apps/views/shared
mkdir -p /Users/allen/proj/london_price/london_price/apps/views/shared
mkdir -p /Users/allen/proj/london_price/london_price/apps/views/london_price
mkdir -p /Users/allen/proj/london_price/london_price/apps/views/london_price
mkdir -p /Users/allen/proj/london_price/london_price/assets
mkdir -p /Users/allen/proj/london_price/london_price/assets/javascripts
mkdir -p /Users/allen/proj/london_price/london_price/assets/javascripts
mkdir -p /Users/allen/proj/london_price/london_price/assets/javascripts
mkdir -p /Users/allen/proj/london_price/london_price/assets/stylesheets
mkdir -p /Users/allen/proj/london_price/london_price/assets/stylesheets
mkdir -p /Users/allen/proj/london_price/london_price/assets/stylesheets
mkdir -p /Users/allen/proj/london_price/london_price/assets/templates
mkdir -p /Users/allen/proj/london_price/london_price
mkdir -p /Users/allen/proj/london_price/london_price
mkdir -p /Users/allen/proj/london_price/london_price
mkdir -p /Users/allen/proj/london_price/london_price/models
mkdir -p /Users/allen/proj/london_price/london_price
mkdir -p /Users/allen/proj/london_price/london_price
mkdir -p /Users/allen/proj/london_price/london_price
mkdir -p /Users/allen/proj/london_price/london_price/public
mkdir -p /Users/allen/proj/london_price/london_price
mkdir -p /Users/allen/proj/london_price/london_price
mkdir -p /Users/allen/proj/london_price/london_price/spec
mkdir -p /Users/allen/proj/london_price/london_price/spec/apps
mkdir -p /Users/allen/proj/london_price/london_price/spec/apps
mkdir -p /Users/allen/proj/london_price/london_price/spec
mkdir -p /Users/allen/proj/london_price/london_price/vendor
mkdir -p /Users/allen/proj/london_price/london_price/vendor/assets
mkdir -p /Users/allen/proj/london_price/london_price/vendor/assets/javascripts
mkdir -p /Users/allen/proj/london_price/london_price/vendor/assets/javascripts
/Users/allen/.rvm/gems/ruby-2.0.0-p0/gems/deano-1.2.0/lib/deano/commands/name_command.rb:25:in `gsub': invalid byte sequence in US-ASCII (ArgumentError)
from /Users/allen/.rvm/gems/ruby-2.0.0-p0/gems/deano-1.2.0/lib/deano/commands/name_command.rb:25:in `clean_string'
from /Users/allen/.rvm/gems/ruby-2.0.0-p0/gems/deano-1.2.0/lib/deano/commands/new_project_generator_command.rb:29:in `block (2 levels) in call'
from /Users/allen/.rvm/gems/ruby-2.0.0-p0/gems/deano-1.2.0/lib/deano/commands/new_project_generator_command.rb:28:in `open'
from /Users/allen/.rvm/gems/ruby-2.0.0-p0/gems/deano-1.2.0/lib/deano/commands/new_project_generator_command.rb:28:in `block in call'
from /Users/allen/.rvm/gems/ruby-2.0.0-p0/gems/deano-1.2.0/lib/deano/commands/new_project_generator_command.rb:23:in `each'
from /Users/allen/.rvm/gems/ruby-2.0.0-p0/gems/deano-1.2.0/lib/deano/commands/new_project_generator_command.rb:23:in `call'
from /Users/allen/.rvm/gems/ruby-2.0.0-p0/gems/deano-1.2.0/bin/deano:11:in `block in '
from /Users/allen/.rvm/gems/ruby-2.0.0-p0/gems/deano-1.2.0/bin/deano:9:in `each'
from /Users/allen/.rvm/gems/ruby-2.0.0-p0/gems/deano-1.2.0/bin/deano:9:in `'
from /Users/allen/.rvm/gems/ruby-2.0.0-p0/bin/deano:19:in `load'
from /Users/allen/.rvm/gems/ruby-2.0.0-p0/bin/deano:19:in `'
from /Users/allen/.rvm/gems/ruby-2.0.0-p0/bin/ruby_noexec_wrapper:14:in `eval'
from /Users/allen/.rvm/gems/ruby-2.0.0-p0/bin/ruby_noexec_wrapper:14:in `'
```

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at lib/deano/commands/name_command.rb:25, where clean_string calls gsub, and follow the call from new_project_generator_command.rb:28-29. Reproduce the deano app-generation command shown in the issue and verify that project creation completes without the invalid byte sequence ArgumentError.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.