markbates / markbates/configatron
include? called against unset configatron setting returns nothing
Open
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 593
- Forks
- 74
- PR merge metrics
- No merged PRs in 30d
Description
When you reference a variable that is not set with .include? it does not return false as you would expect, it returns "".
```
irb(main):009:0> x.ugh.include?(1)
=>
```
Considering it definitely does not include it, I would expect a false response.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the behavior in irb with an unset configatron setting and call include? on it. Locate the implementation and existing tests for unset settings, then add a regression test and make the result false when the value does not include the queried item.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100