mark-gerarts / mark-gerarts/automapper-plus

Throw Exception instead "return;"

Open
#52 2 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
PHP
Stars
562
Forks
32
PR merge metrics
No merged PRs in 30d

Description

Please, change this comment to real exception
https://github.com/mark-gerarts/automapper-plus/blob/d5ca462e99deae8c6628d15d5c67ab479ad1b8b9/src/MappingOperation/DefaultMappingOperation.php#L49
When this library is one block of big system, bugs like this is hard detection, if here will be real exception, life will be better, i think

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with src/MappingOperation/DefaultMappingOperation.php at the linked line and read the surrounding comment and return statement to understand the unhandled condition. Replace the silent return with an exception as requested, then run the repository's relevant tests to confirm the failure is surfaced without breaking existing mappings.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.