mariuszgromada / mariuszgromada/MathParser.org-mXparser

atan2

Open
#330 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
955
Forks
158
PR merge metrics
No merged PRs in 30d

Description

Has there been any consideration to adding atan2 to the list of binary functions?
https://en.wikipedia.org/wiki/Atan2

Right now I have to do a work around where I first calculate the angle using atan and then add pi or 2pi based on the values of the x and y components.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the binary-function registry and the tests for existing trigonometric functions in MathParser.org-mXparser. Trace how binary functions are exposed to parsed expressions and verify the expected atan2 angle across component quadrants. Done means atan2 is available as a binary function with coverage for the documented behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.