marigold-dev / marigold-dev/tzvote

Block voting button if are on the last block of a period or on the first block

Open
#7 1 comment 0 reactions 1 assignee View on GitHub

@zamrokk is already working on this.

Since Mar 16, 2022.

enhancement
Dominant language
TypeScript
Stars
11
Forks
4
PR merge metrics
No merged PRs in 30d

Description

SUMMARY: Block voting button if are on the last block of a period or on the first block

IMPACT:

- last block : vote will not be taken into account because when the block will be forged, it will appear on the next period and so, be rejected by the smart contract
- first block : first block needs to be forged on tezos for the next period index to be display on the chain, then update of the oracle will appear on the second block (normally...if no delay), then when voting :
- vote tx is also on 1st block => rejection
- vote tx is also on oracle update or before => rejection
Solution ? compare oracle index and tezos index, if different, not time to vote, if sync, then all is fine for voting. So VOTE button can be displayed

REPRODUCTION:
- last block : vote on last block of voting period
- first block :
- vote on first block
- vote before oracle is updated

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.