marigold-dev / marigold-dev/tzvote
BUG : check public key passed as parameter with source
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 11
- Forks
- 4
- PR merge metrics
- No merged PRs in 30d
Description
On this vote we don't check that the param is correct
https://github.com/marigold-dev/tzvote/blame/mainnet/contracts/tezosTemplate3.jsligo
We need to compare : Tezos.address (Tezos.implicit_account senderHashKey) to Tezos.get_source () to avoid hacks
----
Btw, also change the error label ` "Sender has no rolls and cannot vote"` there is no more rolls
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with mainnet/contracts/tezosTemplate3.jsligo, using the issue’s requested comparison between Tezos.address (Tezos.implicit_account senderHashKey) and Tezos.get_source (). Confirm the vote rejects mismatched values and update the error label so it no longer refers to rolls; verify the contract’s relevant behavior before considering it done.
Written by the indexing model from the issue text.
Assessment
- Domain
- blockchain
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100