marigold-dev / marigold-dev/pollinate

Execute `failure_detector` at each gossip round

Open
#49 0 comments 0 reactions 1 assignee View on GitHub

@Gau-thier is already working on this.

Since Jun 3, 2022.

Dominant language
OCaml
Stars
22
Forks
3
PR merge metrics
No merged PRs in 30d

Description

Hum, this is wrong, but works regarding what we do.
On the SWIM paper, I think the failure_detection is executed at each round of the gossip. Since we do that before each round, this is kinda ok. But I think we do need to add two things:
- round ID in each failure_detection message
- failure_detector_config as argument here, because user must be able to set whatever is relevant for his/her business case.

_Originally posted by @gsebil08 in https://github.com/marigold-dev/pollinate/pull/33#discussion_r885440991_

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.