marigold-dev / marigold-dev/gas-station

The Max calls per sponsee is wrong

Open
#45 2 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug good first issue
Dominant language
Python
Stars
5
Forks
2
PR merge metrics
No merged PRs in 30d

Description

I hadn't realized that we had a different understanding of this condition. The goal is not to limit the number of calls for a specific sponsee (giving their address and so on). The goal is to limit the number of calls for new users, in order to sponsor only the first N calls for each user.

I believe this could be a good first issue too for someone else (cc @lykimq). What's your opinion @quentin-burg?

Make sure

  • to change the database scheme
  • to write a migration script
  • to check the conditions correctly in the API
  • that the UI is changed too, before merging on staging/ghostnet.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the database schema, migration setup, API condition checks, and UI code related to the max-calls-per-sponsee setting. Confirm how calls and users are represented, then update the behavior so only the first N calls for each new user are sponsored; done means the schema, migration, API checks, and UI all reflect that rule before staging or ghostnet.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api, backend, database, frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.