marigold-dev / marigold-dev/deku

Make `Update_root_hash` action payload same as consensus.mligo'a payload contents

Open
#181 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

backlog
Dominant language
OCaml
Stars
82
Forks
17
PR merge metrics
No merged PRs in 30d

Description

The variant, `Update_root_hash`, should be 1 : 1 with the variant encoded in the consensus.mligo

https://github.com/marigold-dev/sidechain/blob/4e8d4bd021ef0819f40a8bd9e958420d6fcc1752/tezos_interop/consensus.mligo#L288

At the moment, it isn't,

```reason
Update_root_hash(state_root_hash)
```

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the Update_root_hash variant at consensus.mligo line 288 in the linked sidechain revision, then locate the corresponding action definition in this repository. Compare the payload contents and confirm the implementation matches the consensus.mligo variant; done means the two representations are identical.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
blockchain
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.