margelo / margelo/react-native-nitro-sqlite

Add support for detox

Open
#13 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement feature-request triage:needs-reproduction
Dominant language
C
Stars
565
Forks
53
Avg merge
1d 21h
Merged PRs (30d)
18

Description

Add detox support by exclude some libs in build.gradle
What went wrong

If run android app via detox test, it will failed during the build.
Issue is with duplicate .so libraries.

Possible fix

Excludes from Build.gradle, then detox works.

   excludes = [
              "META-INF",
              "META-INF/**",
              "**/libjsi.so",
              "**/libreact_nativemodule_core.so",
              "**/libturbomodulejsijni.so",
              "**/libc++_shared.so",
              "**/libfbjni.so",
              "**/libhermes_executor.so"     
      ]

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in android/build.gradle at the packaging exclusions referenced by the issue. Run the Android app through a Detox test to reproduce the duplicate .so library build failure, then verify that the build completes successfully with the required exclusions and that Detox can run.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, react-native
Domain
build-system, mobile
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.