margelo / margelo/react-native-nitro-fetch
Parts of Fetch API not implemented
Open
Nobody has claimed this yet.
bug
- Dominant language
- C++
- Stars
- 997
- Forks
- 50
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 14
Description
Before submitting a new issue
- I tested using the latest version of the library, as the bug might be already fixed.
- I tested using a supported version of react native.
- I checked for possible duplicate issues, with possible answers.
Bug summary
Quickly tried this out in a fairly big project, and it failed on a few edge cases that I ran into (apparently not edge casey enough):
Headersinterface not implemented (used to do stuff likeresponse.headers.get()), see https://developer.mozilla.org/en-US/docs/Web/API/HeadersResponse.clonenot implemented, used by msw and others, see https://developer.mozilla.org/en-US/docs/Web/API/Response/clone
It's not an exhaustive list, and I'd be down to send a PR if you agree that this is useful.
Library version
0.1.3
Environment info
N/A
Steps to reproduce
- …
- …
Reproducible example repository
N/A
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the library's Fetch API implementation and examine how Headers and Response are currently exposed. Use the linked MDN behavior as the reference, then add coverage for response.headers.get() and Response.clone(); done means both reported gaps work in the supported React Native environment.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, react-native
- Domain
- api, mobile
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100