margelo / margelo/react-native-nitro-fetch
NetworkInspector capture bounds do not hold after reconfiguration or for long-lived sockets
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 997
- Forks
- 50
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 14
Description
Lowering maxEntries does not trim existing entries; subsequent records only shift one entry so the configured bound can remain exceeded indefinitely. WebSocket message arrays are unbounded, and generated cURL strings can retain request bodies beyond maxBodyCapture. I plan to validate finite non-negative integer limits, trim entries when reconfigured, add an explicit per-socket message history limit while retaining cumulative counters, and enforce the configured capture limit in inspector cURL strings with a truncation notice. The standalone cURL helper will remain lossless. The new history bound is observable and will be documented.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the NetworkInspector capture-limit configuration and its WebSocket message and inspector cURL paths; compare them with the standalone cURL helper. Done means limits reject invalid values, reconfiguration trims stored entries, socket history is bounded while counters remain cumulative, and inspector cURL bodies are truncated with a notice without changing the standalone helper.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, react-native
- Domain
- devtools, networking
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100