marcosgriselli / marcosgriselli/SwipeableTabBarController

Enhancement: Changing direction of swipe based on semanticContentAttribute

Open
#89 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Swift
Stars
1.5k
Forks
108
PR merge metrics
No merged PRs in 30d

Description

Your issue may already be reported!
Please search on the [issue track](https://github.com/marcosgriselli/SwipeableTabBarController/issues?utf8=✓&q=) before creating one.

## Expected Behavior

The TabBar swipe should work according to the semanticContentAttribute
## Current Behavior

Currently it swipes Left to Right even when semantics is Right to Left

## Possible Solution

## Steps to Reproduce (for bugs)

1. Set semantics of tabBar right to left (can be done in attributes inspector)
2.Try swiping
3. When swiping left, it goes to the right and vice versa
4.

## Environment

* SwipeableTabBarController version:
* Device and OS running tests:
* Demo project link:

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file, test, or entry point is named in the issue. Reproduce the behavior with the tab bar's semanticContentAttribute set to right-to-left, then trace the swipe handling and verify that left and right swipes select tabs in the expected direction.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.