marcosgriselli / marcosgriselli/Sizes

Safe area is inherited from the device running Sizes

Open
#14 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Swift
Stars
1.2k
Forks
53
PR merge metrics
No merged PRs in 30d

Description

## Expected Behavior
When the size is changed to a new device, the view controller should have the same safe area that it would have if it were running on that device.

## Actual Behavior
When the size is changed to a new device, the safe area does not change.

## Steps to Reproduce the Problem

1. Run Sizes on an iPhone 8 Plus
2. Select Readme
3. The safe area is small (ok)
4. Change size to iPhone Xs
5. The safe area remains small (not ok)
6. For contrast, you can run Sizes on an iPhone Xs and see the difference:

||iPhone 8 Plus Simulator| iPhone Xs Simulator|
|-|-|-|
|iPhone 8 Plus Size|![simulator screen shot - iphone 8 plus - 2018-10-14 at 13 13 54](https://user-images.githubusercontent.com/5491536/46919254-1e585080-cfb3-11e8-91bd-93c302ffb76e.png)|![simulator screen shot - iphone xs - 2018-10-14 at 13 14 08](https://user-images.githubusercontent.com/5491536/46919286-a8081e00-cfb3-11e8-9a57-0c4459b01c68.png)|
|iPhone Xs Size|![simulator screen shot - iphone 8 plus - 2018-10-14 at 13 14 05](https://user-images.githubusercontent.com/5491536/46919258-2ca66c80-cfb3-11e8-9bdb-f73569019bfa.png)|![simulator screen shot - iphone xs - 2018-10-14 at 13 14 16](https://user-images.githubusercontent.com/5491536/46919295-b3f3e000-cfb3-11e8-83d5-8025b8c03cfa.png)|

## Specifications

- Version: Any
- Platform: Any
- Subsystem: Any

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the issue using the listed iPhone 8 Plus and iPhone Xs simulator steps, then trace how changing the selected size updates the view controller's safe area. Done means the safe area matches the selected device rather than the device running Sizes, including the contrast cases described in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, swift
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.