marcomorain / marcomorain/garcon

In the non-Linux version of sendfile(), why do you pass &file_length?

Open
#4 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
25
Forks
1
PR merge metrics
No merged PRs in 30d

Description

In the non-Linux version of sendfile(), why do you pass &file_length? At least in the FreeBSD version, it just takes a regular size_t. And in that case, there'd be no need to check file_length again; just check the return value.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the non-Linux sendfile() implementation and compare its argument type and return-value handling with the FreeBSD signature mentioned in the issue. Determine whether the current call is incorrect or redundant, then validate the corrected behavior across the supported non-Linux path.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
networking, operating-systems
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.