marchof / marchof/java-almanac
Some feedback for Java 28 diffs
Open
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 1.1k
- Forks
- 78
- Avg merge
- 3h 53m
- Merged PRs (30d)
- 7
Description
- I hope reflective preview APIs are marked from the regular ones: reflective ones can be used by non-preview programs to support running in a preview enabled runtime. (
IdentityExceptionis not reflective, all other preview APIs added by value objects are reflective) - There are preview class files in the JDK 28 distributions: See https://github.com/openjdk/jdk/blob/master/doc/value-class-preview.md, they are in
META-INF/preview. You can maybe create a separate diff page or notation to indicate the difference between theMETA-INF/previewclasses and the normal classes.
According to #141 your tool uses ASM, so I anticipate these tweaks to be relatively easy to your tool.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the ASM usage described in #141 and read doc/value-class-preview.md to understand reflective preview APIs and META-INF/preview classes. Done means the generated diffs distinguish reflective preview APIs from regular ones and identify classes from META-INF/preview, with the output behavior covered by the tool's existing checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100