maptalks / maptalks/maptalks.js
Popup does not follow marker when bearing is 0.
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 4.5k
- Forks
- 511
- Avg merge
- 3d 58m
- Merged PRs (30d)
- 1
Description
maptalks-gl v0.124.4 Related to https://github.com/maptalks/maptalks.js/issues/2510
**Bug description**
Popup is drifting away from marker on panning when the bearing is 0. Doesn't happen on even a slightly tilted map.
**How to reproduce**
Open https://joric.github.io/stalker, zoom down to level 6-8, select a tall marker to open popup, drag the map. Popup moves like it's on a different altitude when the map proection is straight down (bearing is 0).
**Comment**
Looks like renderer checks if bearing is 0 and doesn't update popup altitude but updates markers altitude. I'd love to have an option to disable altitude on bearing 0 altogether also, as per https://github.com/maptalks/maptalks.js/issues/2510 PLEASE make heightFactor or enableAltitude mutable to fix the parallax issue, it's currently the biggest problem (for the top-down view).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue at https://joric.github.io/stalker with a tall marker at zoom 6–8, bearing 0, then pan the map. Start by tracing the renderer's popup and marker altitude updates; done means the popup remains aligned with its marker while panning in the top-down view without regressing tilted maps.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100