maptalks / maptalks/maptalks.js
enableSimplify does not work for 3d
Open
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 4.5k
- Forks
- 511
- Avg merge
- 3d 58m
- Merged PRs (30d)
- 1
Description
See #2331. Essentially, simplify code needs 3d support when enableAltitude is `true` and z coordinates exist. Maptalks currently uses 2d code of the simplify library, there's a branch https://github.com/mourner/simplify-js/tree/3d that supports 3d.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading issue #2331 and tracing the simplify path used when enableSimplify is enabled. Compare the current 2D simplify-js usage with the simplify-js 3d branch, using enableAltitude and existing z coordinates as the scenario to verify. Done means simplification works for 3D geometry without breaking the current 2D behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100