mapstruct / mapstruct/mapstruct

Raise error if qualifiedBy does not result in any match

Open
#533 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
7.7k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

Currently, if you specify `qualifiedBy=..` and the methods passed into the `QualifierSelector` are all filtered out, we return the original list of methods.

Instead, we should raise an error statiing that no method qualifies for the given qualifiers.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at QualifierSelector and trace how qualifiedBy filtering currently falls back to the original methods. Done means the no-match case reports an error for the supplied qualifiers while normal matching remains unchanged; add focused coverage for both paths.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.