mapshare / mapshare/map-share-frontend
Re implement logic for handleEditReview
@kc-leung is already working on this.
Since May 18, 2019.
- Dominant language
- JavaScript
- Stars
- 0
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
1. User clicks an 'Edit' button of the review to modify.
2. 'Review Modal' is opened
3. The review is rendered on the Review Modal.
4. User modify some fields in the review
5. User clicks a 'Save' button of the review to save
6. 'Review Modal' is closed
7. Background is reloaded
8. New Review content is displayed.
AsIs Flow
- When the user clicks 'Edit' button, it calls 'handleEditReview'
- 'handleEditReview' sets review._id in the state and calls this.props.toggleEditReview(true);
- component pass reviewId from the state
- What if we can write.
ToBe
- When the user clicks 'Edit' button, it calls 'handleEditReview'
- 'handleEditReview' calls this.props.openEditReviewModal(review_.id);
- 'openEditReviewModal' load review and calls this.props.toggleEditReview(true);
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.