maproulette / maproulette/maproulette-frontend
User settings for Task Confirmation Modal not working as expected
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 167
- Forks
- 39
- Avg merge
- 16h 34m
- Merged PRs (30d)
- 11
Description
What happened?
When a user configures their preferences to disable Task Confirmation Modal, then the user will not see the modal at all, when the project/challenge doesn't require it. However, the modal window still shows up.
I confirm that I've tried on a challenge that doesn't require confirmation. I've also double-checked on the project settings, to ensure that the confirmation is optional.
Steps to reproduce
- Set your preferences, disable the Task Confirmation Modal.
- Work on a task from a challenge that doesn't require task confirmation
- After hitting any of the completion buttons (i fixed it, can't complete, etc.) the modal comes up:
Environment
Linux on Firefox, Vivaldi
Additional information
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue in Firefox or Vivaldi using the listed challenge and project settings, then trace the Task Confirmation Modal preference and the completion-button flow. Done means the modal stays hidden for optional tasks when the user disables it, while required confirmations continue to appear.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100