maproulette / maproulette/maproulette-frontend
Non-Applicable TagFix-Tagchanges cause infinite loading instead of not beeing applicable
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 167
- Forks
- 39
- Avg merge
- 16h 34m
- Merged PRs (30d)
- 11
Description
What happened?
I used to use a "trick" to be able to have TagFix-Challenges where there sometimes are tag fixes and sometimes you have to edit manually. I just set a tag edit where the only edit is to remove a key that will never be there. So there are no edits to be made, which up until recently, resulted in the "Yes"-Button vanishing and your only options were to do edits yourself or click "no".
Now, having non-applicable edits just results in infinite loading in multiple places and the Yes-Button still beeing there. While I can see that the previous behaviour was probably not intended, I think now is worse as it allows me to press "Yes" on "null"-Edits. The edit tags-function is also not available.
And besides of my wierd edge-use-case, not having applicable edits happens quite often even when using the feature as intended. I think it should be restored to it's previous behaviour.
Steps to reproduce
- Have a tag-fix challenge
- Have a task where for some reason, no edits can be made. (e.g. all the changes are already appllied)
Environment
Chrome on Windows
Additional information
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing a TagFix challenge where no applicable edits can be made, such as when all changes are already applied, and observe the affected loading and Yes-button behavior. Done means non-applicable edits no longer load indefinitely or allow confirmation of null edits, and the previous no-applicable-edits behavior is restored.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100