maplibre / maplibre/geojson-cpp
Reintroduce mapbox variant.hpp
Open
@louwers is already working on this.
Since Apr 13, 2025.
- Dominant language
- C++
- Stars
- 4
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
Mapbox' variant implementation results in much smaller binaries. +5% binary file size to use `std::variant` is likely not worth it https://github.com/maplibre/maplibre-native/pull/2946#issuecomment-2422487665
Out of binary size considerations we should therefore re-introduce variant.hpp. But this fork has little practical value if we do that.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.