mapillary / mapillary/mapillary-js

High res image tiles not loaded correctly in slider for regular to panorama comparison

Open
#277 0 comments 0 reactions 1 assignee View on GitHub

@oscarlorentzon is already working on this.

Since Jun 5, 2018.

affects-component bug
Dominant language
TypeScript
Stars
516
Forks
89
PR merge metrics
No merged PRs in 30d

Description

Basic information

MapillaryJS version: 2.12.0
System/Browser: All

Steps to Reproduce Behavior
  1. Create a viewer and initialize it with the slider:
var viewer = new Mapillary.Viewer(
    "<element-id>",
    "<client-id>",
    "<regular-key>",
    {
        component: {
            cover: false,
            direction: false,
            imagePlane: false,
            sequence: false,
            slider: { initialPosition: 1, keys: { foreground: '<regular-key>', background: '<pano-key>' } },
        },
    });
  1. Change to non-3D mode.
  2. Change the position of the slider so that the panorama is visible
  3. Zoom in.
Expected behavior

The high res tiles are loaded for the whole visible part of the panorama

Actual behavior

For some views only part of the panorama is updated with high res tiles and the rest stays in low res.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.