mapillary / mapillary/mapillary-js
Handle non-zero border on viewer container
Open
@oscarlorentzon is already working on this.
Since Mar 21, 2017.
affects-render
discussion
- Dominant language
- TypeScript
- Stars
- 516
- Forks
- 89
- PR merge metrics
- No merged PRs in 30d
Description
When a non-zero border is used the library does not behave properly because the canvas is shifted and it is not entirely shown because of the fact that offset* values are used. This leads to the following when having top and left borders.
- Only top left of part photo is shown leading to faulty bouncing among other things.
- All DOM rendered items that use percentages like TagComponent render in the wrong place.
Relevant reference:
https://developer.mozilla.org/en-US/docs/Web/API/CSS_Object_Model/Determining_the_dimensions_of_elements
Currently the library does not support non-zero border. Maybe a note about this in the docs is enough for now.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.