mapillary / mapillary/OpenSfM

Eigen::MappedSparseMatrix

Open
#970 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
3.8k
Forks
899
PR merge metrics
No merged PRs in 30d

Description

Eigen::MappedSparseMatrix is deprecated. It affects opensfm/src/third_party/pybind11. In eigen.h, the following modifications are needed:

-        value = Eigen::MappedSparseMatrix<Scalar, Type::Flags, StorageIndex>(
+        value = Eigen::Map<Eigen::SparseMatrix<Scalar, Type::Flags, StorageIndex> >(

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open opensfm/src/third_party/pybind11/eigen.h and locate the Eigen::MappedSparseMatrix usage described in the issue. Make the specified Eigen API update, then verify that the deprecated reference is gone and the affected OpenSfM binding still builds.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-vision
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.