Do you need the in-tree copy of gtest?
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 3.8k
- Forks
- 899
- PR merge metrics
- No merged PRs in 30d
Description
The distributed FindGlog.cmake and FindGtest.cmake diverge from the upstream's interface: the modern gtest and glog seem to link through the targets glog::glog and GTest::gtest, whereas you rely on the GLOG_LIBRARY variable. This is somewhat of a hindrance when trying to build OpenSfM with system-distributed versions of gtest/glog and creates a necessity for patching the CMakeLists before the build: https://github.com/NixOS/nixpkgs/pull/152957/files#diff-393b1ae08ea4ab1b6c409e106cdf13ef1ac32d9777af6744bb895bfaf37b9346R52
Do you need the custom copy of gtest and custom Find* files in the first place?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the distributed FindGlog.cmake and FindGtest.cmake files, then check the CMakeLists.txt usage referenced in the issue. Determine whether the in-tree gtest and custom find modules are needed; done means OpenSfM can build with system-distributed gtest and glog targets without patching CMakeLists.txt.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100