mapillary / mapillary/OpenSfM

units of distortion parameters in the brown conrady camera model

Open
#700 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

question sfm-reconstruction
Dominant language
Python
Stars
3.8k
Forks
899
PR merge metrics
No merged PRs in 30d

Description

I want to replace the image metadata extraction step with my own meta data - this seems straightforward, as I can get all these (focal_x, focal_y, c_x, c_y) in pixels (from my own metadata extraction) and then convert to scaled coordinates by dividing by max(width, height).

I do have an initial set of distortion parameters (k1,k2,k3, p1,p2) for the brown conrady model, but these are in pixel coordinates - when scaling these as well, I get a lot of non-convergence errors from Ceres in the reconstruction step - naturally, also these parameters would also be quite large in scaled coordinates ( e.g. k3 -> k3*width^6), but I haven't seen any such large parameter values posted here - Can you clarify in what units openSFM expects these parameters ?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the image metadata extraction and reconstruction steps described in the issue, including the focal, principal-point, and Brown-Conrady distortion parameters. Confirm the units expected by the camera model and whether scaling the distortion values causes the reported Ceres non-convergence; document the verified units and conversion guidance.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
computer-vision
Issue type
Documentation
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.