mapillary / mapillary/OpenSfM

networkx graphiz api change causes error in `plot_matches --graph`

Open
#627 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
3.8k
Forks
899
PR merge metrics
No merged PRs in 30d

Description

Running plot_matches --graph fails with

  File "./OpenSfM/bin/plot_matches", line 64, in <module>
    nx.draw_graphviz(

This is probably due to API change with networkx. If we replace that line with
nx.drawing.nx_agraph.graphviz_layout(graph) it works but I can't figure out how to get the edge_color argument correctly.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at ./OpenSfM/bin/plot_matches around line 64 and reproduce the failure with plot_matches --graph. Check the NetworkX drawing call and the proposed nx.drawing.nx_agraph.graphviz_layout replacement, then verify that graph mode runs and edge colors remain correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
computer-vision
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.