mapillary / mapillary/OpenSfM

Error in executing plot_inliers

Open
#588 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
3.8k
Forks
899
PR merge metrics
No merged PRs in 30d

Description

Hello

I have error in executing plot_inliers. Error message is follow:

Plotting tracks for image00293.jpg - image00296.jpg...
Traceback (most recent call last):
File "/source/OpenSfM/bin/plot_inliers", line 968, in
create_tracks_figure(image1, image2, ds, save, single)
plot_bootstrapped_reconstruction(fw, ip, 4, p1, p2, robust_tracks, linked_tracks, graph, data)
File "/source/OpenSfM/bin/plot_inliers", line 589, in plot_bootstrapped_reconstruction
reconstruction, _, _ = reconstruct.bootstrap_reconstruction(data, graph, ip.im1, ip.im2, pm1, pm2)
TypeError: bootstrap_reconstruction() missing 1 required positional argument: 'p2'

The function "bootstrap_reconstruction" in reconstruction.py needs 7 parameters. However, the function "reconstruct.bootstrap_reconstruction" in plot_inliers call with 6 parameters.

Is this bug?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at bin/plot_inliers, especially plot_bootstrapped_reconstruction, and compare its reconstruct.bootstrap_reconstruction call with the definition in reconstruction.py. Run plot_inliers on the reported image pair and verify that the call no longer raises the missing-argument TypeError.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
computer-vision
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.