dataset.py: unpickle whitelist incomplete for python3.14/numpy1/numpy2 variations
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 3.8k
- Forks
- 899
- PR merge metrics
- No merged PRs in 30d
Description
Hi, heads up we're having opensfm tests stutter for python314Packages.opensfm at Nixpkgs, missing numpy._core.numeric._frombuffer in load_matches' modules_map, an attribute which probably originates from numpy2 but I didn't check. Cf. logs under the bottom spoiler at https://github.com/NixOS/nixpkgs/pull/436700#issuecomment-4961931059.
EDIT: Hold on, we're maybe having an automation failure, picking up the wrong tag... The tests ran correctly against https://github.com/mapillary/OpenSfM/commit/238744cdf3b5d50149c50d136a87f7fea25ad5cd, the failure is reproducible for python314Packages.opensfm and numpy at 2.5.0
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in dataset.py at load_matches and inspect the modules_map used for unpickling. Reproduce the OpenSfM test failure with Python 3.14 and numpy 2.5.0, then update the whitelist for the reported numpy._core.numeric._frombuffer variation and verify the tests no longer fail.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- numpy, python
- Domain
- computer-vision
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 74/100