JSON export changed behaviour in 1.11.0
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 12.9k
- Forks
- 2k
- Avg merge
- 4h 27m
- Merged PRs (30d)
- 8
Description
In 1.11.0 when exporting to JSON all properties are included in the export. Previously only those with a modified value would be included. Not sure if this is intended or by mistake. In my case it creates issues as objects have values now that normally would be undefined and get their default values for specific cases.
An easy example would be that I use the layer tint to set the tint of all objects in that layer, unless an object have a value in the gfx class with a color property. This no longer works as all objects in a layer will have a #ffffff value etc.
JSON diff for export in 1.11.0 compared to old behaviour.
**Expected behavior**
If intended, a feature request instead to have option in export settings for old behaviour.
**Specifications:**
- OS: Linux (KDE Neon)
- Tiled Version: 1.11.0
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the JSON export in Tiled 1.11.0 and compare it with the previous behavior shown in the attached JSON diff. Check whether all properties are exported instead of only modified values, and determine whether the result is an unintended regression or requires an export option for the old behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 45/100