mapeditor / mapeditor/tiled

Toolbar extension button hard to see on dark themes

Open
#3,678 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

usability
Dominant language
C++
Stars
12.9k
Forks
2k
Avg merge
4h 27m
Merged PRs (30d)
8

Description

The button for toolbar extensions is a dark grey colour, which makes it hard to see when using the Tiled Fusion theme is a dark grey or other darkish colour:
image
If the Native theme inherits its colour from the OS on some OSes (it doesn't on Windows 10), this issue affects it too.

It would be nice if these buttons changed their colour based on the theme colours, if that's possible. The QSS selector for them is apparently QToolBarExtension, but since Tiled doesn't use QSS, I doubt that information is useful.

Unsurprisingly, other icons in Tiled suffer from this issue as well, such as the layer locks, the "Dynamically wrap tiles" button, and the Animation Editor button, however, I suspect that those, being set by Tiled rather than Qt, are less likely to have some built-in way to recolour them. Some of them are raster images, which are presumably even harder to recolour at runtime, and would probably need light/dark alternates.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the toolbar extension button's visibility problem with the Tiled Fusion dark theme, then compare it with the Native theme on the affected operating systems. Review how toolbar icons and theme colours are handled, including the other icons named in the issue; done means the extension button is clearly visible on dark themes without making light themes unclear.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
design, desktop
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.