mapeditor / mapeditor/tiled

Pressing Shift while painting with Stamp Brush should start line mode

Open
#3,642 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

usability
Dominant language
C++
Stars
12.9k
Forks
2k
Avg merge
4h 27m
Merged PRs (30d)
8

Description

When trying to use Shift + Stamp Brush to draw lines, I often end up clicking first and then pressing Shift because that feels more natural to me, but in Tiled this doesn't work - it does not begin line-drawing and causes any further cursor movement to do nothing until I let go of the mouse button.

I think it would be more convenient if pressing Shift while already painting would start drawing a line from the cursor's location at that point. If the user releases Shift before the mouse button, then the line should not be drawn, same as the current line-drawing behaviour, but if they're still holding the mouse, they should start painting normally from the current location (Edit: thinking about it more, it should not keep drawing without clicking again, as it's likely if the user changes their mind about painting a line, their cursor isn't somewhere where they want to immediately paint. My suggestion here requires too much preplanning of the user xP).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the interaction with the Stamp Brush: press the mouse button, then hold Shift while painting. Trace the Stamp Brush input handling and line mode entry point; done means Shift starts a line from the cursor position, releasing Shift before the mouse button cancels the line, and changing behavior does not resume painting without another click.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop-dev
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.