mapeditor / mapeditor/tiled

Incorrect redrawing of oversized Tile Collision Shapes

Open
#3,438 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
12.9k
Forks
2k
Avg merge
4h 27m
Merged PRs (30d)
8

Description

When "Show Tile Collisions Shapes" is enabled, the redraw area for the brush is based only on the tiles and does not include the collision that may stick out of the tiles.
In this screenshot, I'm drawing with a 16x16 tile that has a 32x32 collision rectangle. Notice how the brush preview only shows the top left part of the collision, and how there are a bunch of trails left of the other parts of the collision rectangle where I moved my cursor around. The top left of the map contains a single correctly rendered tile+collision, I achieved this by drawing the tile, then changing the zoom to rerender the entire map.
image

I am using 1.9.0, Win10 64-bit, but I imagine this is a much older issue that's got unnoticed because collisions don't normally go beyond the tile's edges.

Edit: Disabling "Show Tile Collision Shapes" after having created a bunch of these glitches doesn't clear all of them, looks like only the chunks with tiles are redrawn:
image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in Tiled by enabling “Show Tile Collisions Shapes” and painting with a tile whose collision extends beyond its bounds. Compare the brush preview and cleanup after disabling collision display; done means oversized collisions redraw fully without trails or stale areas.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics, desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.