mapeditor / mapeditor/tiled

First GID property is always null when using TMXMapReader

Open
#2,933 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
12.9k
Forks
2k
Avg merge
4h 27m
Merged PRs (30d)
8

Description

The first gid property is always null when using the TMXMapReader, the older MapReader used to set it in the buildMap method

```java
tileset = readTileset(xmlPath + tileSetSource);
tileset.setFirstgid(firstGid);
tileset.setSource(tileSetSource);
tilesets.set(i, tileset);
```

I'll create a PR to also set this property in the TMXMapReader.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect the TMXMapReader and compare its tileset handling with the older MapReader buildMap method shown in the issue. Verify that the firstgid value is preserved for the first tileset, then confirm the reader reports the expected property when loading a TMX map.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.