Map::findObjectById should use a lookup
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 12.9k
- Forks
- 2k
- Avg merge
- 4h 27m
- Merged PRs (30d)
- 8
Description
Currently it enumerates all objects recursively until an object matches. In #2712 @bjorn pointed out that this is kinda silly for an ID field. We should add a map<ID, object*> of some kind.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating Map::findObjectById and reviewing how it recursively enumerates objects and how object IDs are managed. Determine where a map from IDs to objects can be maintained; done means findObjectById uses that lookup and still returns the matching object correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100