mapcrafter / mapcrafter/mapcrafter-playermarkers

JSON syntax & missing players

Open
#9 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
14
Forks
6
PR merge metrics
No merged PRs in 30d

Description

Hello,
I edited .js a bit (ready skins from minotar) and created PHP file, searching all players in all worlds.
Based on .js code i managed to make such structure, is it correct? The world name should be filename or the mapcrafter's config names?

Also, some skins are not visible. There are only two players shown on map, although both JSON and counter show 4:
![obraz](https://user-images.githubusercontent.com/7432818/53033220-dd94aa80-3470-11e9-96eb-2c4b8ebeb381.png)
And in json there are four for this map:
![obraz](https://user-images.githubusercontent.com/7432818/53033331-1e8cbf00-3471-11e9-8b41-1b610894a3df.png)

Edit:
I tried to read the plugin code and added dimensions & few other things, but players are still shown in all dimensions...

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the edited .js file, the created PHP file, and the plugin code referenced in the report. Compare the JSON player data with the map configuration and dimension handling, then reproduce the case where four players are counted but only two appear. Done means the world names and dimensions are interpreted correctly and players appear on the appropriate maps.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, json, php
Domain
frontend, web-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.