mapcrafter / mapcrafter/mapcrafter-playermarkers
Unable to know if an error occured or not
- Dominant language
- JavaScript
- Stars
- 14
- Forks
- 6
- PR merge metrics
- No merged PRs in 30d
Description
Please please : stop using booleans to determine if an error occured or not!
In player.php, function is_alex() :
How can you say if the skin is steve or if an error occured here ?
Can you throw a simple exception ? Or even return null instead ?
Thanks.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start in player.php at is_alex() and inspect how its return value is consumed. Determine how callers should distinguish the Steve skin from an error, then update the function and its callers so that distinction is explicit. Done means callers no longer rely on an ambiguous boolean and both outcomes remain handled consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100