mapcrafter / mapcrafter/blockcrafter

1.14 block updates missing?

Open
#8 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
15
Forks
9
PR merge metrics
No merged PRs in 30d

Description

I just pulled a master docker image and build new blocks directory with the latest 1.14.3 jar and my resource pack of preference (Stevens Traditional 64x64 [1.14.3]).

After doing a map render with the new block files I was getting a few unknown block messages:

```
2019-07-02 12:25:57 [INFO] [default] Unknown block minecraft:bamboo age=1,leaves=none,waterlogged=false,
2019-07-02 12:44:46 [INFO] [default] Unknown block minecraft:composter level=0,waterlogged=false,
2019-07-02 13:03:29 [INFO] [default] Unknown block minecraft:sign waterlogged=false,
2019-07-02 13:29:36 [INFO] [default] Unknown block minecraft:lily_pad_rotated rotation=0,waterlogged=false,
2019-07-02 13:29:36 [INFO] [default] Unknown block minecraft:lily_pad_rotated rotation=2,waterlogged=false,
2019-07-02 13:29:36 [INFO] [default] Unknown block minecraft:lily_pad_rotated rotation=1,waterlogged=false,
2019-07-02 13:29:36 [INFO] [default] Unknown block minecraft:lily_pad_rotated rotation=3,waterlogged=false,
2019-07-02 14:37:55 [INFO] [default] Unknown block minecraft:wall_sign waterlogged=false,
```

I think some of these are fixed with the #7 PR, but possibly not the lily_pad_rotated one.

@miclav are you able to confirm about the lily_pad_rotated case?

@m0r13 do you know when you might have time to review and merge all this and update the docker image?

I would try and patch it in myself but I don't really know how to do that with docker.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the block data generated from the 1.14.3 jar and the #7 PR, then reproduce the reported map render with the Docker image. Compare the output against the unknown bamboo, composter, sign, lily_pad_rotated, and wall_sign blocks; done means the supported blocks render without these unknown-block messages and the Docker image includes the update.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, python
Domain
game-dev, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.