mapbox / mapbox/wagyu

Investigate if bounding box check makes quick_clip faster

Open
#85 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
197
Forks
37
PR merge metrics
No merged PRs in 30d

Description

For features that are completely inside a bounding box, it might be faster to simply copy the entire feature at once rather then running through the quick clipping algorithm. However, this would add overhead of search if feature is entirely in a bounding box prior to doing this operation, so it might make operations slower on the whole. This ticket is to investigate the performance of each option.

Method in quesiton: `mapbox::geometry::wagyu::quick_clip::quick_lr_clip`

Ref: https://github.com/mapbox/mapnik-vector-tile/issues/126

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at mapbox::geometry::wagyu::quick_clip::quick_lr_clip and compare clipping with copying features that are completely inside the bounding box. Measure both options, including the overhead of checking containment, using representative geometry. Done means documenting the performance results and which approach is preferable.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.