mapbox / mapbox/wagyu

Compare against PostGIS MakeValid()

Open
#47 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
197
Forks
37
PR merge metrics
No merged PRs in 30d

Description

It would be very interesting to see how Wagyu compares against GEOS/MakeValid in PostGIS both from performance and accuracy. It seems that the method for PostGIS is located [here](https://github.com/postgis/postgis/blob/bd3177743db5cb786deb05d7327f39a5cec2daf6/liblwgeom/lwgeom_geos_clean.c#L373-L667) and perhaps it could be extracted and put into a benchmark.

First step would be to determine how to use this method in a standalone fashion if possible.

/cc @pramsey @strk

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by examining the referenced PostGIS implementation in liblwgeom/lwgeom_geos_clean.c, especially lines 373-667, and determine whether the method can be used standalone. Then identify how Wagyu's existing benchmarks are organized and define a comparison that measures both performance and accuracy. Done means a reproducible benchmark can compare Wagyu with GEOS/MakeValid through PostGIS.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, postgresql
Domain
databases, performance, testing
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.