mapbox / mapbox/wagyu

Support 64bit integer properly

Open
#104 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
197
Forks
37
PR merge metrics
No merged PRs in 30d

Description

The example code utilizes 64bit integer, but it does not support 64bit integer actually.

For instance, slope comparison is done with multiplication of two coordinate delta and therefore, one if each coordinate value exceeds 32bit range, it causes overflow.
Original Clipper utilizes 128bit integer operation to compare slope.

Contributor guide

Open the contributing guide

Research direction

Locate the example code's slope comparison and inspect how multiplication of coordinate deltas can overflow for values beyond the 32-bit range. Compare that operation with the original Clipper's 128-bit integer approach; done means slope comparisons remain correct for 64-bit coordinate values without overflow.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.