mapbox / mapbox/vtvalidate

[cli] new line on final output?

Open
#17 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
15
Forks
3
PR merge metrics
No merged PRs in 30d

Description

When I run the CLI, the final output doesn't end with a `\n` character, which looks a bit wonky. It'd be nice to keep it clean and add a new line!

Looks like [this is intentional](https://github.com/mapbox/vtvalidate/blob/435dcc5a2bb7d6e2cf647991e10a9d6b617836a6/bin/vtvalidate.js#L60), so pardon if I'm missing something!

```
$ vtvalidate fixtures/003/tile.mvt
unknown geometry type $
```

cc @GretaCB

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at bin/vtvalidate.js around line 60, which the issue identifies as the intentional output behavior. Run the CLI with fixtures/003/tile.mvt to reproduce the sample output, then verify that the final output ends with a newline.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
cli
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.