mapbox / mapbox/vtshaver

Move to using `isExpressionFilter`

Open
#43 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
44
Forks
7
PR merge metrics
No merged PRs in 30d

Description

We can likely use `isExpressionFilter` at https://github.com/mapbox/vtshaver/blob/b0d8eb414eda21f6735228d144327e4f79b9e87d/lib/styleToFilters.js#L82-L112 to clean up that code and avoid the commented else block.

This is getting exposed at https://github.com/mapbox/mapbox-gl-js/pull/9530

Contributor guide

Open the contributing guide

Research direction

Start in lib/styleToFilters.js around lines 82-112 and compare the existing logic with isExpressionFilter. Simplify that section while removing the commented else block, then verify that the resulting filter handling preserves the current behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.