mapbox / mapbox/vtshaver

`napi_get_property_names` is buggy in node 10.19

Open
#42 7 comments 0 reactions 1 assignee View on GitHub

@artemp is already working on this.

Since Apr 9, 2020.

bug dependencies
Dominant language
JavaScript
Stars
44
Forks
7
PR merge metrics
No merged PRs in 30d

Description

```c++
napi_get_property_names(_env, _value, &result);
```
erroneously returns `Number` type when property name has only digit literals e.g '123'

This has been fixed in node >=12 (tested 12.16.1, 13.12.0)
/cc @springmeyer

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.