mapbox / mapbox/vtshaver

Upgrading to clang++ 7.x

Open
#21 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
44
Forks
7
PR merge metrics
No merged PRs in 30d

Description

It would be nice to be able to use the latest version of clang++. However we'll hit:

```
In file included from ../src/vtshaver.cpp:1:
In file included from ../src/filters.hpp:4:
In file included from /Users/danespringmeyer/projects/vtshaver/mason_packages/.link/include/mbgl/style/filter.hpp:4:
In file included from /Users/danespringmeyer/projects/vtshaver/mason_packages/.link/include/mbgl/util/feature.hpp:3:
In file included from /Users/danespringmeyer/projects/vtshaver/mason_packages/.link/include/mbgl/util/optional.hpp:3:
/Users/danespringmeyer/projects/vtshaver/mason_packages/osx-x86_64/clang++/7.0.0/include/c++/v1/experimental/optional:11:2: error: " has been removed. Use
instead."
#error " has been removed. Use instead."
```

So, we'll need to upgrade mbgl to avoid this (#9) to a version that includes https://github.com/mapbox/mapbox-gl-native/pull/13049

Contributor guide

Open the contributing guide

Research direction

Start with src/vtshaver.cpp and src/filters.hpp, then inspect the mbgl dependency version and the clang++ 7.0.0 error for experimental/optional. Update mbgl to a version including mapbox/mapbox-gl-native#13049, then verify that the project builds with clang++ 7.x.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.